Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI unit-testing and coverage reports to GitHub Actions #1118

Open
dondi opened this issue Sep 25, 2024 · 8 comments
Open

Migrate CI unit-testing and coverage reports to GitHub Actions #1118

dondi opened this issue Sep 25, 2024 · 8 comments

Comments

@dondi
Copy link
Owner

dondi commented Sep 25, 2024

As seen in #1044 and #1095, our existing use of Travis and Coveralls for automated tests and coverage reports, respectively, has become out of date and potentially no longer feasible given changes to how Travis and Coveralls operate. In the meantime, GitHub introduced their Actions tab and this is a potential replacement for both services

We can explore how to do that and transition accordingly when ready

@dondi
Copy link
Owner Author

dondi commented Sep 25, 2024

Sample repo that has CI set up with GitHub actions: https://github.com/vitejs/vite

@dondi dondi mentioned this issue Sep 25, 2024
41 tasks
@akaiap
Copy link
Collaborator

akaiap commented Oct 9, 2024

  • Documented the migration process and steps in the Wiki. -- Wiki
  • Began studying documentation for workflow file instructions for Github actions

Next Steps for this week

  • - Add to wiki page
  • - Create Branch
  • - Begin writing instructions for the yml file
  • - Test
  • - Create PR

@dondi
Copy link
Owner Author

dondi commented Oct 16, 2024

Branch is ready to go but @akaiap just needs to finish SSH key setup in order to push to the repo. She will do this 10/17 and signal the group if there are any questions

akaiap added a commit that referenced this issue Oct 19, 2024
@akaiap
Copy link
Collaborator

akaiap commented Oct 30, 2024

  • Finished the SSH key setup
  • Additionally, created a pull request with the new changes to the yml file
  • Reviewing workflow for current failing checks

@akaiap
Copy link
Collaborator

akaiap commented Oct 30, 2024

Errors to note after syncing the syncing package-lock.json with package.json:

  1. Deprecated Dependencies --Many dependencies have been outdated or deprecated versions, as seen in the warnings. but it won't stop the workflow from running. But definitely something to note.
  2. There are missing Ubuntu packages required for canvas. These packages are used to build canvas correctly in a linux environment like the one used by Actions.

@dondi
Copy link
Owner Author

dondi commented Nov 6, 2024

We took a look at the latest version of the config file and noticed that the initial core issue with running the latest settings involves the on block in the YAML file

@akaiap can do additional lookup on this value so that we can get the Action to execute at precisely the times that we want (e.g., upon every push vs. upon every PR, etc.)

@ceciliazaragoza found a link that looks like a good start: https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-nodejs

@akaiap
Copy link
Collaborator

akaiap commented Nov 13, 2024

Updates:

Success!

  • CI testing has been successfully integrated into GitHub Actions!
  • The workflow file now completes the build process, runs unit tests, and finishes the build smoothly.
  • During testing, I discovered that Node.js version 20.x was incompatible with the current canvas module, so I downgraded it to 18.x.
    Future notes:
  • To enable the workflow to use a higher version of Node.js, we need to upgrade the canvas package to a version that supports Node.js 20.x. (in package json)

@dondi
Copy link
Owner Author

dondi commented Nov 16, 2024

The review requested for this issue isn’t a traditional “QA” action, but just a general monitoring now that any push to beta—and any branches taken from beta from this point—should automatically a generate a workflow run, seen in the Actions tab:
image

We can review results at the 11/20 meeting and close the issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants