-
-
Notifications
You must be signed in to change notification settings - Fork 648
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes not made.
- Loading branch information
Showing
3 changed files
with
20 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48c3cbc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Commit message is wrong. This is meant to resolve #288
48c3cbc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but could you explain why replacing inline NSDictionary instantiation with dictionaryWithObjectsAndKeys fixed #288?
48c3cbc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mars-lan No problem. As I’ve solved the same problem earlier here. This issue has been introduced in many stackoverflows that using NSDictionary in old way lead to misleading behavior in older devices. I just followed that. I know this is very ridiculous.
48c3cbc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. I totally didn't expect that. I thought the literal NSDictionary is just syntactic sugar for
+[NSDictionary dictionaryWithObjects:forKeys:count:]
(https://clang.llvm.org/docs/ObjectiveCLiterals.html#id2). Anyways, let's see if others can still reproduce #288 after the fix.