Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output layer inconsistency #14

Open
dopplerchase opened this issue Jan 12, 2023 · 0 comments
Open

Output layer inconsistency #14

dopplerchase opened this issue Jan 12, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dopplerchase
Copy link
Owner

When we forked this repo and made a few more flexible changes, there was a missed change. NOTE: This is not a breaking code issue. It is more of an inconsistency.

I am specifically referencing the kernel_size changes we made. The original package by Kyle didn't let you change the convolutional kernel size from the top level method (e.g., models.unet(...)). This made for a limited hyperparameter search for many using unets. Thus, if you go back into the history of the pulls here you will see how we passed the kernel_size paramater up to the top level method.

The issue opened here arises from the changes. Unfortunately, it looks like kernel_size was not passed into the output layer of the 3+ unets. The code issue is here, which is from https://github.com/dopplerchase/keras-unet-collection/blob/main/keras_unet_collection/_model_unet_3plus_2d.py

        OUT = CONV_output(X_decoder[0], n_labels, kernel_size=3, l1=l1, l2=l2,
                          activation=output_activation, name='{}_output_final'.format(name))

        model = Model([IN,], [OUT,])

It is possible that this hard coded kernel with size 3 is in other places, but I have not checked elsewhere yet.

@dopplerchase dopplerchase added the bug Something isn't working label Jan 12, 2023
@dopplerchase dopplerchase self-assigned this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant