Unable to switch from fullscreen to normal mode in SDL

[DublikuntMux]

Summary

When trying to set window.WindowState = WindowState.Normal in fullscreen mode nothing happens with SDL as backend for windowing.

Steps to reproduce

• Platform: Desktop
• Framework Version: .NET Core 10.0
• Silk.NET Version: 2.23.0
• API: OpenGL
• API Version: Any GL version

1. Use this minimal reproducible example:

using System;
using System.Drawing;
using Silk.NET.Input;
using Silk.NET.OpenGL;
using Silk.NET.Windowing;

// ReSharper disable AccessToDisposedClosure

namespace SlikTest;

internal static class Program
{
    private static void Main(string[] args)
    {
        using var window = Window.Create(WindowOptions.Default);

        IInputContext input;
        GL gl = null!;

        window.Load += () =>
        {
            gl = window.CreateOpenGL();
            input = window.CreateInput();
            input.Keyboards[0].KeyDown += (keyboard, _, _) =>
            {
                if (keyboard.IsKeyPressed(Key.Enter))
                {
                    switch (window.WindowState)
                    {
                        case WindowState.Normal:
                            window.WindowState = WindowState.Fullscreen;
                            break;
                        case WindowState.Fullscreen:
                            window.WindowState = WindowState.Normal;
                            break;
                        default:
                            throw new ArgumentOutOfRangeException();
                    }
                }

                if (keyboard.IsKeyPressed(Key.Escape))
                    window.Close();
            };
        };

        window.Render += _ =>
        {
            var color = window.WindowState switch
            {
                WindowState.Normal => Color.Red,
                WindowState.Fullscreen => Color.Green,
                _ => Color.White,
            };
            gl.ClearColor(color);
            gl.Clear(ClearBufferMask.ColorBufferBit);
        };

        window.Run();
    }
}

2. Press Enter to switch to full screen mode
3. Press Enter and the window will not return to normal
4. See bug

[knightfury16]

@DublikuntMux, this issue is not specific to SDL. I reproduced the issue with glfw too with the given code snippet. I am looking into the issue as why it happens.

NB: I dont think you are using SDL in your code, as you are not using the Silk.NET.SDL namespace. And by default, Silk.Net uses glfw.

[knightfury16]

@Perksey, I figured out the problem. Is it ok if I work on a PR for this?

[dos-ise]

@knightfury16 do you have a workaround for this?

[knightfury16]

@dos-ise Actually, this issue is specific to WindowState.FullScreen. As a temporary solution, you can use WindowState.Maximized, which doesn't seem to have the same problem.