Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use System.Threading.Lock in hybrid cache when locking #56638

Closed
1 task done
Meir017 opened this issue Jul 5, 2024 · 3 comments
Closed
1 task done

Use System.Threading.Lock in hybrid cache when locking #56638

Meir017 opened this issue Jul 5, 2024 · 3 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@Meir017
Copy link
Contributor

Meir017 commented Jul 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

The new HybridCache library doesn't use the new Lock object when locking

Describe the solution you'd like

in https://github.com/dotnet/aspnetcore/blob/main/src/Caching/Hybrid/src/Internal/DefaultHybridCache.SyncLock.cs plain objects are used for locking, we could use the new Lock object

Additional context

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jul 5, 2024
@JamesNK
Copy link
Member

JamesNK commented Jul 15, 2024

Using it is worth looking at. I created a new issue that considers replacing it everywhere: #56638

Closing this in favor of the broader issue.

@JamesNK JamesNK closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2024
@Meir017
Copy link
Contributor Author

Meir017 commented Jul 15, 2024

@JamesNK you linked to this issue (by mistake) 😏

@JamesNK
Copy link
Member

JamesNK commented Jul 15, 2024

Opps. This one: #56794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

No branches or pull requests

2 participants