-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumping ws dependency to fix component vulnerability #57536
bumping ws dependency to fix component vulnerability #57536
Conversation
Thanks for doing this, I'm experiencing this issue at my org - much needed! |
Also experiencing this issue at my org - really appreciate the PR! |
Thanks for the change! |
When will this make it into a version of @microsoft/signalr on npm? Looks like the latest version available there contains the impacted version of ws: https://www.npmjs.com/package/@microsoft/signalr?activeTab=code Thanks! |
This change was made in our 10.0 branch, which we're not shipping until next year. I can backport it to 9.0 and 8.0 so that it makes it into our next monthly release - unfortunately the branches are closed right now, so the fix won't ship until December. |
/backport to release/9.0 |
/backport to release/8.0 |
Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/11369683658 |
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/11369685243 |
Actually, I was able to get this merged in time for the 9.0.0 RTM release in November |
When will you publish this fix? For the latest |
Which package are you referring to? The 8.0 SignalR package has been using 7.5.10 for some time now:
|
npm package still contain "ws": "^7.4.5" |
Bumping
ws
dependency to fixComponent Vulnerability
issuews package has a DoS attach vulnerability between v7.0.0 and v7.5.10
Details can be found here; https://security.snyk.io/package/npm/ws
GitHub Code Scanning feature shows a
High Severity
alertDescription
ws
dependency in the package.json is pinned to v7.4.5, and it needs to be updated to at least v7.5.10Fixes #56723