Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up OpenAPI schema handling and support concurrent requests #58024

Open
wants to merge 4 commits into
base: release/9.0
Choose a base branch
from
Open

Fix up OpenAPI schema handling and support concurrent requests #58024

wants to merge 4 commits into from
+224 −13

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Sep 23, 2024 •
edited
Loading

Description

This PR backports #57972 to resolve issues with concurrent requests to OpenAPI documents (fixes #57876).

This PR also addresses a set of issues with generated schemas:

Customer Impact

This PR resolves a set of bugs reported by users of .NET 9 RC 1 for which no viable workarounds exist.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Changes localized to OpenAPI package.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

captainsafia and others added 4 commits September 22, 2024 13:21
@captainsafia
Fix JsonUnmappedMemberHandling attribute handling to close #57981
f471d24
@captainsafia
Fix enum handling for MVC actions to close #57979
01bda26
@captainsafia
Fix self-referential schema handling to close #58006
72c2131
@xC0dex @captainsafia
Fix concurrent request handling for OpenAPI documents (#57972)
a1c2acc 
* fix: Allow concurrent requests

* test: Update test

* test: Use Parallel.ForEachAsync

* feat: Use valueFactory overload

* feat: Pass valueFactory directly
@captainsafia captainsafia requested a review from a team as a code owner September 23, 2024 03:06
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Sep 23, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hi @captainsafia. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @xC0dex