From b4000bfe0d864dbb85c04ebb32fa5132830aacf4 Mon Sep 17 00:00:00 2001 From: Andrew Casey Date: Tue, 10 Sep 2024 16:58:54 -0700 Subject: [PATCH] Add a note about when to validate ping payloads Specifically, it will probably be important for https://github.com/dotnet/aspnetcore/issues/53657. --- src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs b/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs index 05321d3e73e1..689341ddc152 100644 --- a/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs +++ b/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs @@ -1086,6 +1086,8 @@ private Task ProcessPingFrameAsync(in ReadOnlySequence payload) if (_incomingFrame.PingAck) { // TODO: verify that payload is equal to the outgoing PING frame + // This will be particularly important if we implement dynamic window sizing + // (https://github.com/dotnet/aspnetcore/issues/53657). return Task.CompletedTask; }