Skip to content

Commit 32fda98

Browse files
authored
Revert "Add variable for repo root in ImageBuilder container image" (#1883)
Reverts #1876 because it caused issues when flowing to dotnet-docker: see dotnet/dotnet-docker#6869
1 parent bd41302 commit 32fda98

File tree

4 files changed

+5
-21
lines changed

4 files changed

+5
-21
lines changed

eng/docker-tools/Dockerfile.WithRepo

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,5 @@
22
ARG IMAGE
33
FROM $IMAGE
44

5-
# Keep this path in sync with $(containerBuildRepoRoot) in
6-
# eng/docker-tools/templates/steps/init-matrix-build-publish.yml
75
WORKDIR /repo
86
COPY . .

eng/docker-tools/templates/jobs/publish.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ jobs:
153153

154154
- template: /eng/docker-tools/templates/steps/publish-readmes.yml@self
155155
parameters:
156-
publishConfig: ${{ parameters.publishConfig }}
157156
dryRunArg: $(dryRunArg)
158157
condition: and(succeeded(), eq(variables['publishReadme'], 'true'))
159158

eng/docker-tools/templates/steps/init-matrix-build-publish.yml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ steps:
2727
$commonMatrixAndBuildOptions = "$commonMatrixAndBuildOptions --base-override-regex '^(?!mcr\.microsoft\.com)' --base-override-sub '$(public-mirror.server)/'"
2828
}
2929
30-
$containerBuildRepoRoot="/repo"
31-
3230
if ("${{ parameters.versionsRepoRef }}" -ne "") {
3331
$versionsBasePath = "${{ parameters.versionsRepoPath }}/"
3432
$pipelineDisabledCache = "false"
@@ -41,18 +39,14 @@ steps:
4139
$buildRepoName = "$(Build.Repository.Name)"
4240
}
4341
44-
# When multiple repos are checked out in Azure Pipelines, each repo is placed in a subfolder
45-
# under the main working directory. The subfolder is named after the repo.
46-
$containerBuildRepoRoot = "$containerBuildRepoRoot/$buildRepoName"
47-
4842
$engDockerToolsPath = "$(Build.Repository.LocalPath)/$buildRepoName/$(engDockerToolsRelativePath)"
4943
5044
$engPath = "$(Build.Repository.LocalPath)/$buildRepoName/eng"
51-
$manifest = "$containerBuildRepoRoot/$(manifest)"
52-
$testResultsDirectory = "$containerBuildRepoRoot/$testResultsDirectory"
45+
$manifest = "$buildRepoName/$(manifest)"
46+
$testResultsDirectory = "$buildRepoName/$testResultsDirectory"
5347
5448
if ("$(testScriptPath)") {
55-
$testScriptPath = "$containerBuildRepoRoot/$(testScriptPath)"
49+
$testScriptPath = "$buildRepoName/$(testScriptPath)"
5650
}
5751
5852
echo "##vso[task.setvariable variable=buildRepoName]$buildRepoName"
@@ -70,7 +64,6 @@ steps:
7064
echo "##vso[task.setvariable variable=commonMatrixAndBuildOptions]$commonMatrixAndBuildOptions"
7165
echo "##vso[task.setvariable variable=versionsBasePath]$versionsBasePath"
7266
echo "##vso[task.setvariable variable=pipelineDisabledCache]$pipelineDisabledCache"
73-
echo "##vso[task.setvariable variable=containerBuildRepoRoot]$containerBuildRepoRoot"
7467
displayName: Set Common Variables for Matrix, Build, and Publish
7568

7669
- ${{ if ne(parameters.versionsRepoRef, '') }}:

eng/docker-tools/templates/steps/publish-readmes.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
parameters:
2-
- name: publishConfig
3-
type: object
4-
- name: dryRunArg
5-
type: string
6-
default: ""
7-
- name: condition
8-
type: string
9-
default: "true"
2+
dryRunArg: ""
3+
condition: true
104

115
steps:
126
- script: >

0 commit comments

Comments
 (0)