-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Dockerfile template verification for internal servicing validation #5935
Comments
I am experimenting with "snapshot" testing to validate internal templates, using a library like https://github.com/VerifyTests/Verify. The internal Dockerfiles would still be "checked-in", somewhere in the If we made changes to templates, the workflow would go something like this:
Without running tests locally, then the workflow could be this:
@mthalman, curious to hear your opinion on this approach. |
That seems reasonable. We're obviously restricted from being able to build these Dockerfiles as part of verification within the context of GitHub PRs, so this seems like the next best thing. |
This issue was brought up with #5928 (comment)
Our templates support multiple scenarios for dockerfile generation, single and multi-stage are just one example. With internal testing work (#5928) it becomes critical to ensure that no dockerfile template change is ever regressing any of the supported dockerfile generation scenarios, i.e. internal testing.
Verification should include generation of templates and appropriate pipeline run to validate build and test.
Some options:
The text was updated successfully, but these errors were encountered: