Template engine tests hitting known parallelism issue in GetVisualStudioInstances

[marcpopMSFT]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=869444
Build error leg or test failing: Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplate_WithConditions_BasedOnFileName
Pull request: #44859

Error Message

{
  "ErrorMessage": "57005",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=869444
Error message validated: [57005]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 11/14/2024 7:41:30 PM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
2931771	dotnet-sdk	Build	Log	#59223
2931770	dotnet-sdk	Build	Log	#59224
1345553	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53546
2931381	dotnet-sdk	Run Tests in Helix	Log	#59224
2931382	dotnet-sdk	Run Tests in Helix	Log	#59223
1342737	dotnet/sdk	🟣 Build	Log	#53504
1342631	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53510
1340246	dotnet/sdk	🟣 Build	Log	#53499
1342286	dotnet/sdk	Run Tests in Helix	Log	#53529
1341747	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53517
1340537	dotnet/sdk	🟣 Build	Log	#53510
1339118	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53487
1338351	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53452
2926416	dotnet-sdk	Run Tests in Helix	Log	#58634
1333988	dotnet/sdk	🟣 Build	Log	#53350
1333687	dotnet/sdk	🟣 Build	Log	#53263
1333217	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53290
1332127	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53407
1331667	dotnet/sdk	🟣 Build	Log	#53335
1329798	dotnet/sdk	🟣 Build	Log	#53335
1329779	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53350
1328404	dotnet/sdk	🟣 Build	Log	#53354
1328163	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53353
1327562	dotnet/sdk	🟣 Build	Log	#53335
1327533	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53267
2922396	dotnet-sdk	Build	Log	#58849
2922337	dotnet-sdk	Build	Log	#58848
1326942	dotnet/sdk	🟣 Build	Log	#53332
1326792	dotnet/sdk	🟣 Build	Log	#52930
1326518	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52405
2921508	dotnet-sdk	Build	Log	#58849
2921489	dotnet-sdk	Build	Log	#58848
2921487	dotnet-sdk	Build	Log	#58847
1321508	dotnet/sdk	🟣 Build	Log	#53277
2918587	dotnet-sdk	OneLocBuild	Log
2918431	dotnet-sdk	Build	Log	#58634
1319742	dotnet/sdk	Build	Log
1319401	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53250
2917949	dotnet-sdk	Build	Log	#58632
2917647	dotnet-sdk	Build	Log	#58632
2917405	dotnet-sdk	🟣 Build	Log
1318284	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52930
1317140	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52956
1313771	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53194
1314118	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53181
1313699	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52930
2914067	dotnet-sdk	Run TestBuild Tests	Log	#58430
1311959	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52930
1311210	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53175
1310452	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53123
1309560	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52930
1307535	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53135
1307308	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53118
1307306	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52935
2911142	dotnet-sdk	Publish Using Darc	Log
1306260	dotnet/sdk	🟣 Build	Log	#50120

Build	Definition	Test	Pull Request
1323813	dotnet/sdk	dotnet.Tests.dll.19.WorkItemExecution	#53288
1313720	dotnet/sdk	dotnet-watch.Tests.dll.4.WorkItemExecution	#53192
1305262	dotnet/sdk	Microsoft.DotNet.Cli.Test.Tests.GivenDotnetTestBuildsAndRunsTestfromCsprojWithCorrectTestRunParameters.Microsoft.DotNet.Cli.Test.Tests.GivenDotnetTestBuildsAndRunsTestfromCsprojWithCorrectTestRunParameters.GivenAProjectAndMultipleTestRunParametersItPassesThemToVStestConsoleInTheCorrectFormat	#53120

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	13	58

[BrennanConroy]

Template engine tests hitting known parallelism issue in GetVisualStudioInstances

Is there an issue describing the problem? Are there people working on fixing it? We're hitting this in the aspnetcore repo a lot and as far as I'm aware we don't do anything with UWP which is how the sdk resolved the problem.

[baronfel]

@jaredpar sent a PR here with a short-term workaround that we're working to merge: #44930

The 'true' fix is coming in a future VS release, there was some unintended concurrent access to a critical section that wasn't locked.

[tmat]

@baronfel @jaredpar should this issue be closed?

[baronfel]

I don't think so - the tracker is still making recent edits, which impliies it's still being hit.

[tmat]

So the fix above didn't fix it?