From 60dbbc623cc9851eb4989b2792fe75724cddde4c Mon Sep 17 00:00:00 2001
From: Davis Goodin <dagood@microsoft.com>
Date: Mon, 28 Sep 2020 13:09:37 -0500
Subject: [PATCH] Generate tarball smoke-test nuget.config

---
 eng/SourceBuild.Tarball.targets        | 42 ++++++++++++++++++--------
 support/tarball/smoke-testNuGet.Config | 14 ---------
 2 files changed, 30 insertions(+), 26 deletions(-)
 delete mode 100644 support/tarball/smoke-testNuGet.Config

diff --git a/eng/SourceBuild.Tarball.targets b/eng/SourceBuild.Tarball.targets
index 337695f179..a3211831e7 100644
--- a/eng/SourceBuild.Tarball.targets
+++ b/eng/SourceBuild.Tarball.targets
@@ -25,6 +25,8 @@
     Project="SourceBuild.Tarball.DestructiveCleanup.targets"
     Condition="'$(DestructiveIntermediateClean)' == 'true'"/>
 
+  <UsingTask AssemblyFile="$(XPlatSourceBuildTasksAssembly)" TaskName="RemoveInternetSourcesFromNuGetConfig" />
+
   <Target Name="GetTarballDirProps">
     <PropertyGroup>
       <TarballRootDir>$([MSBuild]::NormalizeDirectory('$(TarballRoot)'))</TarballRootDir>
@@ -151,23 +153,39 @@
         Include="$(ProjectDir)support/tarball/build.sh"
         RelativeDestination="build.sh" />
 
-      <!--
-        When building an internal build, the main smoke-test nuget config has authenticated sources
-        in it to generate a full set of smoke-test-prereqs. This isn't necessary in the tarball
-        because we have those smoke-test-prereqs, but we hit authentication errors nonetheless. Copy
-        a trimmed down nuget.config in this case.
-        TODO: Automatically trim down the main nuget.config.
-      -->
-      <TarballCopyFile
-        Condition="Exists('$(ProjectDir)support\tarball\smoke-testNuGet.Config')"
-        Include="$(ProjectDir)support\tarball\smoke-testNuGet.Config"
-        RelativeDestination="smoke-testNuGet.Config" />
-
       <!-- Setup package version props to include both source-built and running PackageVersions.props -->
       <TarballCopyFile
         Include="$(ProjectDir)support\tarball\PackageVersions.props"
         RelativeRoot="artifacts/obj/$(Platform)/Release/" />
     </ItemGroup>
+
+    <!--
+      When building an internal build, the main smoke-test nuget config has authenticated sources in
+      it to generate a full set of smoke-test-prereqs. We need to get rid of these internal feeds in
+      the tarball to avoid hitting authentication errors. (In the tarball, we have those
+      smoke-test-prereqs in a local feed, so this is fine.)
+
+      Use the nuget trimming task to create a tarball nuget.config without the internal feeds, for
+      this case. Importantly, this leaves public feeds alone: when running a public servicing build,
+      we need to use them for runtime packs, and the smoke-test-prereqs tarball won't contain them.
+    -->
+    <PropertyGroup>
+      <FilteredSmokeTestNuGetConfig>$(ArtifactsDir)support\smoke-testNuGet.Config</FilteredSmokeTestNuGetConfig>
+    </PropertyGroup>
+
+    <Copy
+      SourceFiles="$(ProjectDir)smoke-testNuGet.Config"
+      DestinationFiles="$(FilteredSmokeTestNuGetConfig)" />
+
+    <RemoveInternetSourcesFromNuGetConfig
+      NuGetConfigFile="$(FilteredSmokeTestNuGetConfig)"
+      OfflineBuild="false" />
+
+    <ItemGroup>
+      <TarballCopyFile
+        Include="$(FilteredSmokeTestNuGetConfig)"
+        RelativeDestination="smoke-testNuGet.Config" />
+    </ItemGroup>
   </Target>
 
   <Target Name="AddTarballPackages">
diff --git a/support/tarball/smoke-testNuGet.Config b/support/tarball/smoke-testNuGet.Config
deleted file mode 100644
index afbad0b55e..0000000000
--- a/support/tarball/smoke-testNuGet.Config
+++ /dev/null
@@ -1,14 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<configuration>
-  <packageSources>
-    <!--To inherit the global NuGet package sources remove the <clear/> line below -->
-    <clear />
-    <!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
-    <!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
-    <add key="source-built-packages" value="SOURCE_BUILT_PACKAGES" />
-    <add key="api.nuget.org" value="https://api.nuget.org/v3/index.json" />
-    <add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
-    <add key="ProdCon" value="PRODUCT_CONTRUCTION_PACKAGES" />
-    <add key="smoke-test feed" value="SMOKE_TEST_PACKAGE_FEED" />
-  </packageSources>
-</configuration>