Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision on whether parsing should be case-sensitive #3237

Closed
vlada-shubina opened this issue Jun 3, 2021 · 4 comments
Closed

Decision on whether parsing should be case-sensitive #3237

vlada-shubina opened this issue Jun 3, 2021 · 4 comments
Assignees
Labels
need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone

Comments

@vlada-shubina
Copy link
Member

The current parser is case sensitive: --Nullable and --nullable are different options.
We need to decide whether to keep it so with new parser.

If we decide to keep parser case-sensitive, we should probably adopt naming symbols with small character in template.json, to avoid putting entry in dotnetcli.host.json just for case change, and make respective changes in the templates (for example now we have Framework, but langVersion). Alternatively, we can change the case of first letter programmatically.


Originally posted by @vlada-shubina in #3173 (comment)

@vlada-shubina vlada-shubina added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Jun 3, 2021
@vlada-shubina vlada-shubina added this to the September Sprint milestone Jun 3, 2021
@RussKie
Copy link
Member

RussKie commented Aug 18, 2021

I find case sensitivity on Windows rather surprising. E.g. this caught me off-guard:
image

@sayedihashimi
Copy link
Member

I found that being case sensitive was very unexpected.

@vlada-shubina vlada-shubina added need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases and removed triaged The issue was evaluated by the triage team, placed on correct area, next action defined. labels Dec 20, 2021
@vlada-shubina
Copy link
Member Author

No change to this behavior is planned in scope of #2191, keeping the issue opened for discussions.

@YuliiaKovalova YuliiaKovalova added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Jan 3, 2023
@YuliiaKovalova
Copy link
Member

Close with Low Priority + no major feedback has been received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

No branches or pull requests

5 participants