Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make decision on TargetFrameworkOverride parameter in templates #3261

Closed
vlada-shubina opened this issue Jun 9, 2021 · 4 comments
Closed
Assignees
Labels
area: template-content The issue is related to content of template packages managed in this repo (/template_feed) need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone

Comments

@vlada-shubina
Copy link
Member

Templates have parameter TargetFrameworkOverride which is hidden from users.

Decision needed whether it should be kept (and documented) or removed from all .NET templates.

@vlada-shubina vlada-shubina added area: template-content The issue is related to content of template packages managed in this repo (/template_feed) need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases labels Jun 14, 2021
@vlada-shubina vlada-shubina added this to the Backlog milestone Jun 14, 2021
@vlada-shubina vlada-shubina added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Jun 14, 2021
@baronfel
Copy link
Member

Internal Usage:

  • dotnet/templating
  • dotnet/winforms

External usage:

This seems much more broadly in-use than baselines, and it's often used to set a TargetFramework or conditionally include a set of package references. It seems worth keeping, but I'm not sure that it's any more special than any other symbol. Perhaps the documentation or examples about how symbols are evaluated at template instanciation could be highlighted?

@vlada-shubina
Copy link
Member Author

It's more of the question whether we want to keep it in those templates:

  • dotnet/templating
  • dotnet/winforms

Effectively, those templates have 2 framework parameters:

  • Framework - choice with restricted values (net6.0, net5.0, ...)
  • TargetFrameworkOverride - text, accepts any text value (hidden)

We made a trade-off when implementing new idioms in those templates and TargetFrameworkOverride parameter is not considered when evaluating flavor to be used, so 2 choices here:

  • we keep parameter in and implement logic to try to consider it when determining features to use in generated template
  • we remove the parameter

@baronfel
Copy link
Member

Linking https://github.com/dotnet/sdk/issues/22769 as a request for something like TargetFrameworkOverride to allow setting the TFM uniformly on templates.

@vlada-shubina vlada-shubina removed the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Apr 19, 2022
@YuliiaKovalova YuliiaKovalova added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Jan 3, 2023
@YuliiaKovalova
Copy link
Member

We decided not to change it for now.

@YuliiaKovalova YuliiaKovalova closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: template-content The issue is related to content of template packages managed in this repo (/template_feed) need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

No branches or pull requests

3 participants