-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Microsoft.IO.Redist package version for CPM to version 6.0.1 #8248
Conversation
Looks to me like this will impact Line 18 in 5d43d89
|
I built this branch locally and examined Microsoft.TemplateEngine.Authoring.Tasks to ensure no new package references were added it its nuspec, IO.Redist.dll does not appear in the content (the "excludeassets" is preserved from the MSBuild reference). I do see that the new version of IO.Redist is added to <dependentAssembly>
<assemblyIdentity name="Microsoft.IO.Redist" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-6.0.0.1" newVersion="6.0.0.1" />
</dependentAssembly> I don't think MSBuild even honors these - maybe we should stop shipping them. @rainersigwald |
@ericstj @rainersigwald what are the next steps I should take here? Should I exclude the reference in source build like I did in installer? |
I think it would be nice to know if you could actually remove that config file, since it mentions things which aren't included in the package at all and may be a higher version than what's provided by MSBuild. This is yet another Task that's responsible for updating MSBuild's dependencies. We need an SDK to avoid these cc @baronfel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make things worse than what was here before, but you should follow up on eliminating the config file.
@rainersigwald is there a flag to not generate that config file I can include in this PR? |
@marcpopMSFT yes, you can set the following two properties to disable the creation of an app.config file for .NET Framework: <AutoGenerateBindingRedirects>false</AutoGenerateBindingRedirects>
<GenerateSupportedRuntime>false</GenerateSupportedRuntime> |
No description provided.