Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional VerificationEngine improvements/features #5472

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Oct 17, 2022

Problem

Several functional gaps and shortcommings were identified during integrating VerificationEngine into sdk integration tests
#3868

Solution

Added:

  • optional explicit include list for verification (for cases where we need to verify just few or single file(s))
  • ability to prepend testing method name to verification subdir
  • ability to more colsely influence verification subditr name (custom distinguisher, template parameters in name are switchable)
  • delete templating outputs if they are in temp location

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@JanKrivanek JanKrivanek requested a review from a team as a code owner October 17, 2022 16:59
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful improvements, only couple of wording/naming suggestions

/// <summary>
/// If set to true - the instantiation params are not appended to verification subdirectories.
/// </summary>
public bool? DoNotAppendParamsToScenarioName { get; init; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a nullable here? Should it just default to false?

Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes LGTM

@JanKrivanek JanKrivanek merged commit 12c2cdb into dotnet:main Oct 20, 2022
@JanKrivanek JanKrivanek deleted the verify-engine-improve branch October 20, 2022 13:37
@JanKrivanek
Copy link
Member Author

/backport to release/7.0.2xx

@github-actions
Copy link
Contributor

Started backporting to release/7.0.2xx: https://github.com/dotnet/templating/actions/runs/3297652737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants