-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional VerificationEngine improvements/features #5472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful improvements, only couple of wording/naming suggestions
src/Microsoft.TemplateEngine.Authoring.CLI/Commands/Verify/VerifyCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.CLI/LocalizableStrings.resx
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
/// <summary> | ||
/// If set to true - the instantiation params are not appended to verification subdirectories. | ||
/// </summary> | ||
public bool? DoNotAppendParamsToScenarioName { get; init; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a nullable here? Should it just default to false?
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Authoring.TemplateVerifier/TemplateVerifierOptions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes LGTM
/backport to release/7.0.2xx |
Started backporting to release/7.0.2xx: https://github.com/dotnet/templating/actions/runs/3297652737 |
Problem
Several functional gaps and shortcommings were identified during integrating VerificationEngine into sdk integration tests
#3868
Solution
Added:
Checks:
#nullable enable
to all the modified files ?