Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Problem

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Solution

The arcade SDK update introduced stricter analyzer enforcement. Fixed two IDE analyzer errors in test projects:

  • IDE0044 in MockInstallerFactory.cs: Added readonly to _factoryId field
  • IDE0048 in XunitLoggerProvider.cs: Added parentheses to clarify operator precedence
// Before: ?? applied to result of string concatenation (unintended)
messageBuilder.AppendLine(firstLinePrefix + lines.FirstOrDefault() ?? string.Empty);

// After: ?? applied to FirstOrDefault() result (intended)
messageBuilder.AppendLine(firstLinePrefix + (lines.FirstOrDefault() ?? string.Empty));

Note: An accidentally committed nuget.exe file has been removed from the branch. Please squash commits when merging to remove it from history (force push is not available in my environment).

Checks:

  • Added unit tests

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits November 25, 2025 22:12
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 0t3vsblobprodcus362.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • 4myvsblobprodcus32.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • k4kvsblobprodcus344.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • n3kvsblobprodcus335.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • o3svsblobprodcus318.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.Mocks/Microsoft.TemplateEngine.Mocks.csproj (dns block)
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.TestHelper/Microsoft.TemplateEngine.TestHelper.csproj (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • rcxvsblobprodcus328.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.Mocks/Microsoft.TemplateEngine.Mocks.csproj (dns block)
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.TestHelper/Microsoft.TemplateEngine.TestHelper.csproj (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update dependencies from dotnet/arcade [release/8.0.3xx] Update dependencies from dotnet/arcade Nov 25, 2025
Copilot AI requested a review from marcpopMSFT November 25, 2025 22:18
Copilot finished work on behalf of marcpopMSFT November 25, 2025 22:18
@marcpopMSFT
Copy link
Member

@copilot don't add nuget.exe to a repo ever. Please remove that from history as well, don't just revert.

Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot don't add nuget.exe to a repo ever. Please remove that from history as well, don't just revert.

I cannot rewrite git history because force push is not available in my environment. I can remove nuget.exe from the current branch and add it to .gitignore, but you would need to squash the commits or rebase the branch yourself to remove it from history. Alternatively, you could close this PR and I can create a fresh one without the file.

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot finished work on behalf of marcpopMSFT November 26, 2025 00:19
@marcpopMSFT
Copy link
Member

@copilot do you not have permissions to rebase yourself?

Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot do you not have permissions to rebase yourself?

I can run git rebase, but I cannot force push afterward, which is required to update the remote branch after a rebase. The report_progress tool I use for pushing only supports regular pushes, not force pushes. You would need to rebase/squash the branch yourself, or alternatively close this PR so I can create a fresh one with only the necessary changes.

Copilot finished work on behalf of marcpopMSFT November 26, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants