Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates create compile errors in solutions with Central Package Management (CPM) #300

Open
cremor opened this issue May 9, 2023 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cremor
Copy link

cremor commented May 9, 2023

  1. Create or open a solution with Central Package Management (CPM)
  2. Add a new test project via one of the test project templates.
  3. Notice that there are compile errors. The root error is NU1008 Projects that use central package version management should not define the version on the PackageReference items but on the PackageVersion items

Related: dotnet/aspnetcore#48569

@Evangelink
Copy link
Member

Marking as blocked just to wait for guidance as to what's the right way to fix it.

@cremor
Copy link
Author

cremor commented Jun 5, 2023

See dotnet/templating#6187 (comment)

@Evangelink
Copy link
Member

@YuliiaKovalova Do you think we should start working on this for test templates or shall we wait for the more global solution to be provided by your team (as specified in this comment dotnet/templating#6187 (comment))?

@YuliiaKovalova
Copy link
Member

@YuliiaKovalova Do you think we should start working on this for test templates or shall we wait for the more global solution to be provided by your team (as specified in this comment dotnet/templating#6187 (comment))?

TE was transferred to the different team.
@baronfel please advise here.

@baronfel
Copy link
Member

@Evangelink the template engine is owned by the SDK team now, specifically @MiYanni and @joeloff are the engineering owners. I would recommend you implement the workaround from 6187 with the following addition: add --no-restore to the call to dotnet add package for each package you add. This will prevent a large amount of overhead. Instead, you can do a final restore PostAction like many templates do today at the end of the package additions.

@Evangelink
Copy link
Member

Thank you @YuliiaKovalova and @baronfel. I'll schedule that.

@Evangelink Evangelink added help wanted Extra attention is needed and removed blocked labels Jan 23, 2024
@Evangelink
Copy link
Member

@cvpoienaru please help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants