Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Supporting iPad Pro - master / detail #5

Open
JulesMoorhouse opened this issue Jan 6, 2022 · 3 comments
Open

Question: Supporting iPad Pro - master / detail #5

JulesMoorhouse opened this issue Jan 6, 2022 · 3 comments

Comments

@JulesMoorhouse
Copy link

I’ve just noticed an issue when using an iPad Pro.

While using NavigationLink opening child views would open in the detail area on iPad. The parent view is shown in the master aka left hand panel.

However, with XNavigation all my views, including child views open in the master aka left hand panel.

I’ve added the DestinationView protocols.

I’m not sure how to specify where my child views should open?

@bhaskar-dj
Copy link

I am faced with the same issue. I have had to add a separate condition for UISplitViewController in UIViewController+Hierarchy to get around this issue at my end. Also, the caller would have to specify which stack they want to push from.

@bhaskar-dj
Copy link

@dcvz I can post my solution in a PR, but I'd need access to push to the repo

@mickhitz
Copy link

mickhitz commented Aug 28, 2022

I have the same requirement. Would be great, if @Dvcz could integrate it ... or if @bhaskar-dj could post the changes here (or give more hints on how to do it myself). Would appreciate it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants