From 564ecc6d246f29cf1fae8d75695aa6b66f4fd7d0 Mon Sep 17 00:00:00 2001 From: developer-carsony Date: Wed, 17 Jun 2020 14:44:14 -0500 Subject: [PATCH] Add test case Cannot use serverless.cli.log as it causes test case to fail --- __tests__/fixtures/lambda-layer.js | 2 ++ __tests__/get-dependency-list.js | 9 +++++++++ get-dependency-list.js | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 __tests__/fixtures/lambda-layer.js diff --git a/__tests__/fixtures/lambda-layer.js b/__tests__/fixtures/lambda-layer.js new file mode 100644 index 0000000..43b8689 --- /dev/null +++ b/__tests__/fixtures/lambda-layer.js @@ -0,0 +1,2 @@ +require('/opt/lambdaLayer.js'); +require('test-dep/file'); diff --git a/__tests__/get-dependency-list.js b/__tests__/get-dependency-list.js index 38641dd..d141fcd 100644 --- a/__tests__/get-dependency-list.js +++ b/__tests__/get-dependency-list.js @@ -119,3 +119,12 @@ test('understands local named dependencies', (t) => { t.true(list.some(item => item.endsWith('dep-local-named.js'))); t.true(list.some(item => item.endsWith('local/named/index.js'))); }); + +test('skip dependencies like /opt/lambaLayer.js', (t) => { + const fileName = path.join(__dirname, 'fixtures', 'lambda-layer.js'); + + const list = getDependencyList(fileName, serverless); + + t.true(list.some(item => item.indexOf(`/opt/lambdaLayer.js`) == -1)); + t.true(list.some(item => item.match(/test-dep/))); +}); diff --git a/get-dependency-list.js b/get-dependency-list.js index 6b1a872..6000a54 100644 --- a/get-dependency-list.js +++ b/get-dependency-list.js @@ -25,7 +25,7 @@ module.exports = function(filename, serverless) { function handle(name, basedir, optionalDependencies, peerDependenciesMeta) { const moduleName = requirePackageName(name.replace(/\\/, '/')); if (moduleName === null) { - serverless.cli.log(`[serverless-plugin-include-dependencies]: Module not found, skipping ${name}`); + console.log(`[serverless-plugin-include-dependencies]: Module not found, skipping ${name}`); return null; }