Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colour issues with pop-ups #12

Open
leftygray opened this issue May 4, 2022 · 19 comments
Open

Colour issues with pop-ups #12

leftygray opened this issue May 4, 2022 · 19 comments

Comments

@leftygray
Copy link

Hi, I have noticed an issue with the text and background of some popups.

Some examples shown here:
Dracula-Rstudio-package-update
Dracula-Rstudio-popup
(second picture shows pop-up in Rmarkdown of results when you run inline R, mean(cars$speed in this case).

I have tried tweaking colors in the .rstheme file I have but nothing seems to stick.
@MarcioFCMartins
Copy link

I have submitted a pull request that fixes some of those issues. The package update is one of them. The rmarkdown pop-up I'll have to look into later on.

Sadly it seems that development here is a little stale, feel free to try my fork: https://github.com/MarcioFCMartins/rstudio

@leftygray
Copy link
Author

Thanks for responding and pointing me to your fork which fixes a few other issues.

I will keep an eye out for your fix to the rmarkdown popup.

@leftygray leftygray reopened this May 6, 2022
@MarcioFCMartins
Copy link

I think I found a fix. I am not great with CSS so it's just trial and error. Here's a preview:

image

@leftygray
Copy link
Author

Thanks that seems to work.

@jlxAtNovozymes
Copy link

I have submitted a pull request that fixes some of those issues. The package update is one of them. The rmarkdown pop-up I'll have to look into later on.

Sadly it seems that development here is a little stale, feel free to try my fork: https://github.com/MarcioFCMartins/rstudio

Hi, awesome work. I really appreciated your version. but there is still a minor bug, pls take a look at the image below
image

@MarcioFCMartins
Copy link

MarcioFCMartins commented Apr 12, 2023 via email

@jlxAtNovozymes
Copy link

I think I fixed this issue this afternoon. But honestly the table rows act up pretty often. Hopefully it's fixed for now. A quarta, 12/04/2023, 14:45, jlxAtNovozymes @.> escreveu:
…
I have submitted a pull request that fixes some of those issues. The package update is one of them. The rmarkdown pop-up I'll have to look into later on. Sadly it seems that development here is a little stale, feel free to try my fork: https://github.com/MarcioFCMartins/rstudio Hi, awesome work. I really appreciated your version. but there is still a minor bug, pls take a look at the image below [image: image] https://user-images.githubusercontent.com/90908083/231477272-57795ddd-d537-4b25-8204-3d14d16466d6.png — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIKR7THTEZ7UQ25FHDFGIV3XA2WYPANCNFSM5VAWJSVQ . You are receiving this because you commented.Message ID: @.>

Hi, Martins. a big thanks, we've pulled the latest version and it works. a small small suggestion below:
image

text color issue in popping up windows just below menu bar, haha

@MarcioFCMartins
Copy link

I tried fixing that pop-up but I can't figure out a way to identify the CSS selector for it. I tried using breakpoints to pause the animation, but can't make it work. Looks like it will stay that way for now.

On another note, I am trying a slightly modified version of the theme with (slightly) increased UI contrast. I like it better and would like another opinion, feel free to check it out: https://github.com/MarcioFCMartins/rstudio/tree/more-contrast

@jlxAtNovozymes
Copy link

I tried fixing that pop-up but I can't figure out a way to identify the CSS selector for it. I tried using breakpoints to pause the animation, but can't make it work. Looks like it will stay that way for now.

On another note, I am trying a slightly modified version of the theme with (slightly) increased UI contrast. I like it better and would like another opinion, feel free to check it out: https://github.com/MarcioFCMartins/rstudio/tree/more-contrast

Hi, it's better now, thanks

@jlxAtNovozymes
Copy link

I tried fixing that pop-up but I can't figure out a way to identify the CSS selector for it. I tried using breakpoints to pause the animation, but can't make it work. Looks like it will stay that way for now.

On another note, I am trying a slightly modified version of the theme with (slightly) increased UI contrast. I like it better and would like another opinion, feel free to check it out: https://github.com/MarcioFCMartins/rstudio/tree/more-contrast

Hi, I pull your latest version, but I spot 2 minor problems
the first is as below
image

the second one is that when you hover over "white" item, that row of item you hover will be poped up

@jlxAtNovozymes
Copy link

I tried fixing that pop-up but I can't figure out a way to identify the CSS selector for it. I tried using breakpoints to pause the animation, but can't make it work. Looks like it will stay that way for now.
On another note, I am trying a slightly modified version of the theme with (slightly) increased UI contrast. I like it better and would like another opinion, feel free to check it out: https://github.com/MarcioFCMartins/rstudio/tree/more-contrast

Hi, I pull your latest version, but I spot 2 minor problems the first is as below image

the second one is that when you hover over "white" item, that row of item you hover will be poped up

Hi, I guess the "poped up" problem may have something with event listener, when I remove the one below, it works
image

@MarcioFCMartins
Copy link

Are you sure you are using the latest version? The header of the package updater should look a little different

In my end the package updater looks fine running Rstudio 2023.03.0, but I added the class shown in your screenshot to hopefully fix it for you too.

@jlxAtNovozymes
Copy link

Are you sure you are using the latest version? The header of the package updater should look a little different

In my end the package updater looks fine running Rstudio 2023.03.0, but I added the class shown in your screenshot to hopefully fix it for you too.

Hi, Marcio, I pulled again, it works, haha, thanks a lot for your contribution, it's amazing

@jlxAtNovozymes
Copy link

Are you sure you are using the latest version? The header of the package updater should look a little different
In my end the package updater looks fine running Rstudio 2023.03.0, but I added the class shown in your screenshot to hopefully fix it for you too.

Hi, Marcio, I pulled again, it works, haha, thanks a lot for your contribution, it's amazing

one more suggestion, I'm not sure this one can be done or not.
could you change look of scroll bar inside panes same as scroll bar inside "global options"

this is scroll bar inside panes
image

this is scroll bar inside "global options > appearance > editor theme:"
image

@MarcioFCMartins
Copy link

image

I made the scroll bar in the windows look more like the one in the panes. I think it's much easier to see the bars now.

@jlxAtNovozymes
Copy link

image

I made the scroll bar in the windows look more like the one in the panes. I think it's much easier to see the bars now.

Hi, You are an expert in CSS, haha.
I'm thinking is that possible to make scroll bar like this below:
image

I personally think it's more consistent, what do you think, haha

@MarcioFCMartins
Copy link

I see what you mean, but I find the colors in that bar to be very similar (it probably depends on your monitors), which makes seeing where the scrollbar is very hard.

I think I'll change the colors to something more consistent with the rest of the theme, but with increased contrast.

@jlxAtNovozymes
Copy link

I see what you mean, but I find the colors in that bar to be very similar (it probably depends on your monitors), which makes seeing where the scrollbar is very hard.

I think I'll change the colors to something more consistent with the rest of the theme, but with increased contrast.

haha, I guess you are a perfectionist, thanks a lot. if you can find a more consistent color, that will be perfect. what I like is transparent, haha, could you do me a favor to tell me how to make scroll bar in panes look like below (transparent and without big ocntrast):
image

@MarcioFCMartins
Copy link

MarcioFCMartins commented Apr 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leftygray @MarcioFCMartins @jlxAtNovozymes