Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: fix queries for prop create index, and for primary keys #377

Closed
wants to merge 1 commit into from

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Nov 7, 2013

they were totally broken ;)

@dresende
Copy link
Owner

dresende commented Nov 8, 2013

I'm going to move DML part to an external module. I've done it, just need a few more checks. Change can then be done there.

@dresende dresende closed this Nov 8, 2013
@kapouer
Copy link
Contributor Author

kapouer commented Nov 8, 2013

Really ? i found node-orm2 more appealing precisely because it bundles the drivers,
so all drivers are supposed to be on-par quality-wise.

@dresende
Copy link
Owner

dresende commented Nov 8, 2013

Sorry, I meant DDL (database synching). I'm doing the move now to https://github.com/dresende/node-sql-ddl-sync

@dresende
Copy link
Owner

dresende commented Nov 8, 2013

The module is mine, so they will be kept on par. The difference is that in the module I and any contributors can focus on table synching (avoiding dropping table and recreating when a new property is needed).

@kapouer
Copy link
Contributor Author

kapouer commented Nov 8, 2013

i understand, in fact i was afraid you were talking about splitting each database driver in its own module.

@dresende
Copy link
Owner

dresende commented Nov 9, 2013

I just made the PR #383, will merge it now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants