Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Using UNSAFE_componentWillReceiveProps in strict mode is #146

Open
carminoplata opened this issue Nov 11, 2020 · 11 comments
Open

Comments

@carminoplata
Copy link

Hi everybody,

Does someone deal with this warning?

`Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state

Please update the following components: Rating, RatingAPILayer`

@dreyescat
Copy link
Owner

dreyescat commented Nov 15, 2020

Yep. We need to refactor the component to get rid of this deprecated method.

I'm open to contributions.

The #134 issue was created to track the move towards a controlled component that will let us to get rid of this deprecated lifecycle method.

@bayramn
Copy link

bayramn commented Aug 9, 2021

I still have same issue. How can I resolve it?

@carlocilento
Copy link

The issue is still present as of January 2022 :/

@mleister97
Copy link

Issue does still exist

im28 added a commit to im28/react-rating that referenced this issue Feb 25, 2022
@BorjaRafolsMartinez
Copy link

Fixed it in here Selectra-Dev/react-rating#b76396d4c9c1680153817d7869a6d152d1985a90

@mariomeraz
Copy link

@arcasoy
Copy link

arcasoy commented Jul 30, 2022

Are there any plans to merge those changes^ into this repo?

@Yvad60
Copy link

Yvad60 commented Jul 30, 2022

The issue still exists July 2022

@mariomeraz
Copy link

Are there any plans to merge those changes^ into this repo?

Is Fork, and no have idea...

@Phasor
Copy link

Phasor commented Jan 27, 2023

Any update as of January 2023? Issue is still here.

@Roger5791
Copy link

Any Update....?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests