program: update pmm invariant (#1506)

* program: pmm-config-update-invariant

* correct ordering of validate

* lints

---------

Co-authored-by: Chris Heaney <chrisheaney30@gmail.com>

Author: 0xbigz

programs/drift/src/instructions/admin.rs

@@ -4386,9 +4386,13 @@ pub fn handle_update_protected_maker_mode_config(
     ctx: Context<UpdateProtectedMakerModeConfig>,
     max_users: u32,
     reduce_only: bool,
+    current_users: Option<u32>,
 ) -> Result<()> {
     let mut config = load_mut!(ctx.accounts.protected_maker_mode_config)?;
 
+    if current_users.is_some() {
+        config.current_users = current_users.unwrap();
+    }
     config.max_users = max_users;
     config.reduce_only = reduce_only as u8;
 

programs/drift/src/instructions/user.rs

@@ -2803,6 +2803,17 @@ pub fn handle_update_user_protected_maker_orders(
 
     validate!(!user.is_being_liquidated(), ErrorCode::LiquidationsOngoing)?;
 
+    validate!(
+        protected_maker_orders != user.is_protected_maker(),
+        ErrorCode::DefaultError,
+        "user already {} protected maker mode",
+        if protected_maker_orders {
+            "in"
+        } else {
+            "out of"
+        }
+    )?;
+
     user.update_protected_maker_orders_status(protected_maker_orders)?;
 
     let mut config = load_mut!(ctx.accounts.protected_maker_mode_config)?;

programs/drift/src/lib.rs

@@ -1659,8 +1659,9 @@ pub mod drift {
         ctx: Context<UpdateProtectedMakerModeConfig>,
         max_users: u32,
         reduce_only: bool,
+        current_users: Option<u32>,
     ) -> Result<()> {
-        handle_update_protected_maker_mode_config(ctx, max_users, reduce_only)
+        handle_update_protected_maker_mode_config(ctx, max_users, reduce_only, current_users)
     }
 }
 

sdk/src/adminClient.ts

@@ -4136,10 +4136,15 @@ export class AdminClient extends DriftClient {
 
 	public async updateProtectedMakerModeConfig(
 		maxUsers: number,
-		reduceOnly: boolean
+		reduceOnly: boolean,
+		currentUsers: undefined
 	): Promise<TransactionSignature> {
 		const updateProtectedMakerModeConfigIx =
-			await this.getUpdateProtectedMakerModeConfigIx(maxUsers, reduceOnly);
+			await this.getUpdateProtectedMakerModeConfigIx(
+				maxUsers,
+				reduceOnly,
+				currentUsers
+			);
 
 		const tx = await this.buildTransaction(updateProtectedMakerModeConfigIx);
 
@@ -4150,11 +4155,13 @@ export class AdminClient extends DriftClient {
 
 	public async getUpdateProtectedMakerModeConfigIx(
 		maxUsers: number,
-		reduceOnly: boolean
+		reduceOnly: boolean,
+		currentUsers: undefined
 	): Promise<TransactionInstruction> {
 		return await this.program.instruction.updateProtectedMakerModeConfig(
 			maxUsers,
 			reduceOnly,
+			currentUsers,
 			{
 				accounts: {
 					admin: this.isSubscribed