Skip to content

fix: deficiencies in the EloquentMagicMethodToQueryBuilderRector #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

fix: deficiencies in the EloquentMagicMethodToQueryBuilderRector #422

merged 1 commit into from
Nov 29, 2025
+220 −71

Conversation

@calebdw
Copy link
Contributor

@calebdw calebdw commented Nov 9, 2025

Hello!

This fixes several deficiencies in the rector that prevented the following cases from being converted:

  • static calls on class-strings
  • methods on custom builder classes
  • calls on an unknown models
  • calls on a model intersection with an interface
  • static calls with a model scope

Thanks!

@calebdw calebdw force-pushed the calebdw/push-putlzyxqwzpy branch from e25b021 to 3bf38cd Compare November 9, 2025 05:14
@calebdw calebdw force-pushed the calebdw/push-putlzyxqwzpy branch from 3bf38cd to 87915a1 Compare November 27, 2025 12:54
@peterfox peterfox self-assigned this Nov 29, 2025
@peterfox peterfox added bug Something isn't working enhancement New feature or request labels Nov 29, 2025
@peterfox
Copy link
Collaborator

peterfox commented Nov 29, 2025

This looks really useful @calebdw thank you for your contribution!

@peterfox peterfox merged commit bbdb5ac into driftingly:main Nov 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@peterfox peterfox

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@calebdw @peterfox