Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parts are missing in the encoder part #27

Open
TientJan opened this issue Dec 7, 2022 · 2 comments
Open

Parts are missing in the encoder part #27

TientJan opened this issue Dec 7, 2022 · 2 comments

Comments

@TientJan
Copy link

TientJan commented Dec 7, 2022

Hello, in the MemoryEncoder Class, it seems that there should be added the definition of self.layers. In the if self.cfg.feat_cross_attn part of forward() function, self.layers is used without definition.
@qinliuliuqin
Copy link

Hi, this issue has been mentioned in #23.

@drinkingcoder
Copy link
Owner

Yes. This option should always be False. We will trim our code that is out of date.

@mahao18cm mahao18cm mentioned this issue Jun 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drinkingcoder @TientJan @qinliuliuqin