Do CasePleuralSpaces.{left.right}_pleural_space need to be nullable?

[lamby]

The CasePleuralSpaces.left_pleural_space and CasePleuralSpaces.right_pleural_space fields are nullable (ie. null=True).

Possible Solution

This could be an oversight; perhaps we can make them not-null - it would certainly be tidier and cleaner.

(One outcome here could certainly be that they need to be nullable; just needs good checking)

Checklist before submitting

• I have confirmed this using the officially supported Docker Compose setup using the local.yml configuration and ensured that I built the containers again and they reflect the most recent version of the project at the HEAD commit on the master branch
• I have searched through the other currently open issues and am confident this is not a duplicate of an existing bug
• I provided a minimal code snippet or list of steps that reproduces the bug.
• I provided screenshots where appropriate
• I filled out all the relevant sections of this template

[00rebe]

Hey @lamby, I'm interested in taking a look at this if it's still open.

If we get rid of null=True on CasePleuralSpaces, the implications are:

1. Tidier and cleaner
2. Both left and right lung information must be given. It's not possible to have a case about a left_pleural_space or a right_pleural_space alone.
   • Suggestion: it should be possible to provide information for either lung or both lungs but not no information of either i.e. at max, 1 of left_pleural_space, right_pleural_space can be null.
   • I'm new to django, if this makes sense do you have any suggestions as to how I could implement this?

Thanks,
00rebe

[patrick-ziemke]

Hey, do you mind if I give this a shot?

[JuanGGO]

Hi! is this issue already solved?

[Hiyorimi]

Is this still open?