You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently none of the trait methods contain Result in their type signature, so ? won't work in their implementations.
This encourages a lot of unwrap/expect where I would rather discourage it.
I initially avoided using Result in the trait methods because I want to display the output, so I required Display. However Result doesn't implement Display. I think this might be solvable with a more complicated trait bound combining both Result and Display.
Also, that then forces everyone to return a Result in their implementations, that might be a good thing though since this library aims to be used by beginners to Rust.
This would be a breaking change so the sooner the better!
The text was updated successfully, but these errors were encountered:
Currently none of the trait methods contain
Result
in their type signature, so?
won't work in their implementations.This encourages a lot of unwrap/expect where I would rather discourage it.
I initially avoided using
Result
in the trait methods because I want to display the output, so I requiredDisplay
. HoweverResult
doesn't implement Display. I think this might be solvable with a more complicated trait bound combining both Result and Display.Also, that then forces everyone to return a Result in their implementations, that might be a good thing though since this library aims to be used by beginners to Rust.
This would be a breaking change so the sooner the better!
The text was updated successfully, but these errors were encountered: