Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make methods in handlers protected #34

Open
rubickcz opened this issue Jun 9, 2020 · 1 comment
Open

Make methods in handlers protected #34

rubickcz opened this issue Jun 9, 2020 · 1 comment

Comments

@rubickcz
Copy link
Member

rubickcz commented Jun 9, 2020

The overridable methods should be protected/private, since they are not called outside of the handlers class. For example:

  • get_template_data
  • get_related_objects

etc...
@rubickcz
Copy link
Member Author

Or maybe instead we could make all methods public, since otherwise in subclasses everything would be underscored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rubickcz