Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server sends unexpected response containing both errors and data #622

Open
fguitton opened this issue Jun 30, 2020 · 2 comments
Open

Server sends unexpected response containing both errors and data #622

fguitton opened this issue Jun 30, 2020 · 2 comments
Assignees
@sou-chon
Labels
bug critical

Comments

@fguitton
Copy link
Member

The server send out both errors and data (screenshot N°2) with the GET_STUDY query leading to error rendering on the UI when attempting to query as a non system-admin user. This suggests that permission checking triggers unwanted error output.

image
image
@sou-chon
Copy link
Collaborator

this is the same as #496. Due to the client making requests to some fields that has no permission to.

@sou-chon sou-chon reopened this Jun 30, 2020
@sou-chon
Copy link
Collaborator

sou-chon commented Jul 5, 2020

Ref:
Error policy
https://www.apollographql.com/docs/react/data/error-handling/

fguitton added a commit that referenced this issue Jan 31, 2022
@fguitton
Merge pull request #622 from ideafast/enhance/remove-expiry-info
e7481fe 
Remove notion of expiry info for admin users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sou-chon sou-chon

Labels
bug critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fguitton @sou-chon