Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a generic scaler class that can take a learner class as a parameter #860

Open
ecsalomon opened this issue Aug 24, 2021 · 1 comment

Comments

@ecsalomon
Copy link
Contributor

ecsalomon commented Aug 24, 2021

More model types than LR should have scaled features, and scaling can aid in postmodeling analysis for all model types. Abstract the scaler that @shaycrk wrote and allow it to take a learner class (e.g., xgboost.XGBClassifier or sklearn.linear_model.LogisticRegression) and apply the same scaling at test and train.

@ecsalomon
Copy link
Contributor Author

ecsalomon commented Aug 31, 2021

One potential implementation is to make scaling a top-level key in the config (with sklearn class and params) and to pass all learners to the scaler. Another option would be to make scaling an optional key for model grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant