Skip to content

Commit 2633ff9

Browse files
authored
Add additional checks (#8)
1 parent e061d80 commit 2633ff9

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

src/vmod_querymodifier.c

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,9 @@ static int tokenize_querystring(VRT_CTX, query_param_t **result,
3333

3434
*result = NULL;
3535

36-
if (query_str == NULL) {
37-
VRT_fail(ctx, "query_str is NULL");
38-
*result = NULL;
39-
return -1;
40-
}
36+
CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC);
37+
CHECK_OBJ_NOTNULL(ctx->ws, WS_MAGIC);
38+
AN(query_str);
4139

4240
query_param_t *params_array =
4341
WS_Alloc(ctx->ws, MAX_QUERY_PARAMS * sizeof(query_param_t));
@@ -88,6 +86,9 @@ static int parse_filter_params(VRT_CTX, const char *params_in,
8886
char *params_copy;
8987
size_t count = 0;
9088

89+
CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC);
90+
CHECK_OBJ_NOTNULL(ctx->ws, WS_MAGIC);
91+
9192
if (params_in == NULL || *params_in == '\0') {
9293
*num_filter_params = 0;
9394
return 0;
@@ -157,6 +158,12 @@ static char *rebuild_query_string(VRT_CTX, const char *uri_base,
157158
struct vsb *vsb = VSB_new_auto();
158159
char sep = '?';
159160

161+
CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC);
162+
CHECK_OBJ_NOTNULL(ctx->ws, WS_MAGIC);
163+
AN(uri_base);
164+
AN(params);
165+
AN(filter_params);
166+
160167
if (vsb == NULL) {
161168
VRT_fail(ctx, "VSB_new_auto failed");
162169
return NULL;
@@ -210,6 +217,7 @@ VCL_STRING
210217
vmod_modifyparams(VRT_CTX, VCL_STRING uri, VCL_STRING params_in,
211218
VCL_BOOL exclude_params) {
212219
CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC);
220+
CHECK_OBJ_NOTNULL(ctx->ws, WS_MAGIC);
213221

214222
// Return if the URI is NULL
215223
if (uri == NULL) {

0 commit comments

Comments
 (0)