Skip to content

Commit 5b4cadd

Browse files
authored
Make tokenize parameter split clearer (#4)
1 parent 981d427 commit 5b4cadd

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/vmod_querymodifier.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ static int tokenize_querystring(VRT_CTX, query_param_t **result,
4747
return -1;
4848
}
4949

50-
// Tokenize the query parameters into an array.
5150
for (param_str = strtok_r(query_str, "&", &save_ptr); param_str;
5251
param_str = strtok_r(NULL, "&", &save_ptr)) {
5352

@@ -57,10 +56,14 @@ static int tokenize_querystring(VRT_CTX, query_param_t **result,
5756
return -1;
5857
}
5958

60-
params_array[no_param].name = param_str;
61-
params_array[no_param].value = strchr(param_str, '=');
62-
if (params_array[no_param].value) {
63-
*(params_array[no_param].value++) = '\0';
59+
char *eq = strchr(param_str, '=');
60+
if (eq != NULL) {
61+
*eq = '\0';
62+
params_array[no_param].name = param_str;
63+
params_array[no_param].value = eq + 1;
64+
} else {
65+
params_array[no_param].name = param_str;
66+
params_array[no_param].value = NULL;
6467
}
6568
no_param++;
6669
}

0 commit comments

Comments
 (0)