Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider changing local file path of span and logs? #12

Open
xiaoziv opened this issue Jun 22, 2023 · 2 comments
Open

consider changing local file path of span and logs? #12

xiaoziv opened this issue Jun 22, 2023 · 2 comments

Comments

@xiaoziv
Copy link
Contributor

xiaoziv commented Jun 22, 2023

Since the local path or future S3 object key path 'span/date=2023-06-22/hour=02/minute=12/' is somewhat redundant, would you consider changing it to 'span/2023-06-22/02/12'
@Folyd
Copy link
Collaborator

Folyd commented Jun 22, 2023

Make sense to me, I'm open to changing it.

@pgjbz
Copy link

pgjbz commented Aug 1, 2023

maybe use ISO-8601 format to date and time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Folyd @pgjbz @xiaoziv