Skip to content

Commit 1a3d034

Browse files
authored
Revert "Add sig_v5 support to duo_client_python calls and v2 integrations handler (#188)" (#197)
This reverts commit 42a5a1d.
1 parent 8a78551 commit 1a3d034

File tree

12 files changed

+125
-425
lines changed

12 files changed

+125
-425
lines changed

duo_client/admin.py

Lines changed: 16 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -216,43 +216,11 @@
216216

217217
class Admin(client.Client):
218218
account_id = None
219-
admin_sig_version = 5
220219

221-
def api_call(self, method, path, params, sig_version=admin_sig_version):
220+
def api_call(self, method, path, params):
222221
if self.account_id is not None:
223222
params['account_id'] = self.account_id
224-
return super(Admin, self).api_call(
225-
method,
226-
path,
227-
params,
228-
sig_version=sig_version
229-
)
230-
231-
def json_api_call(self, method, path, params, sig_version=admin_sig_version):
232-
return super(Admin, self).json_api_call(
233-
method,
234-
path,
235-
params,
236-
sig_version=sig_version
237-
)
238-
239-
def json_paging_api_call(self, method, path, params, sig_version=admin_sig_version):
240-
return super(Admin, self).json_paging_api_call(
241-
method,
242-
path,
243-
params,
244-
sig_version=sig_version
245-
)
246-
247-
def json_cursor_api_call(self, method, path, params, get_records_func, sig_version=admin_sig_version):
248-
return super(Admin, self).json_cursor_api_call(
249-
method,
250-
path,
251-
params,
252-
get_records_func,
253-
sig_version=sig_version
254-
)
255-
223+
return super(Admin, self).api_call(method, path, params)
256224

257225
@classmethod
258226
def _canonicalize_ip_whitelist(klass, ip_whitelist):
@@ -2410,8 +2378,8 @@ def get_integrations_generator(self):
24102378
"""
24112379
return self.json_paging_api_call(
24122380
'GET',
2413-
'/admin/v2/integrations',
2414-
{},
2381+
'/admin/v1/integrations',
2382+
{}
24152383
)
24162384

24172385
def get_integrations(self, limit=None, offset=0):
@@ -2430,8 +2398,8 @@ def get_integrations(self, limit=None, offset=0):
24302398
if limit:
24312399
return self.json_api_call(
24322400
'GET',
2433-
'/admin/v2/integrations',
2434-
{'limit': limit, 'offset': offset},
2401+
'/admin/v1/integrations',
2402+
{'limit': limit, 'offset': offset}
24352403
)
24362404

24372405
return list(self.get_integrations_generator())
@@ -2449,8 +2417,8 @@ def get_integration(self, integration_key):
24492417
params = {}
24502418
response = self.json_api_call(
24512419
'GET',
2452-
'/admin/v2/integrations/' + integration_key,
2453-
params,
2420+
'/admin/v1/integrations/' + integration_key,
2421+
params
24542422
)
24552423
return response
24562424

@@ -2473,8 +2441,7 @@ def create_integration(self,
24732441
ip_whitelist=None,
24742442
ip_whitelist_enroll_policy=None,
24752443
groups_allowed=None,
2476-
self_service_allowed=None,
2477-
sso=None):
2444+
self_service_allowed=None):
24782445
"""Creates a new integration.
24792446
24802447
name - The name of the integration (required)
@@ -2500,9 +2467,6 @@ def create_integration(self,
25002467
adminapi_write_resource - <bool:write resource permission>|None
25012468
groups_allowed - <str: CSV list of gkeys of groups allowed to auth>
25022469
self_service_allowed - <bool: self service permission>|None
2503-
sso - <dict: parameters for generic single sign-on> (optional)
2504-
New argument for unreleased feature. Will return an error if used.
2505-
Client will be updated again in the future when feature is released.
25062470
25072471
Returns the created integration.
25082472
@@ -2550,12 +2514,9 @@ def create_integration(self,
25502514
params['groups_allowed'] = groups_allowed
25512515
if self_service_allowed is not None:
25522516
params['self_service_allowed'] = '1' if self_service_allowed else '0'
2553-
if sso is not None:
2554-
params['sso'] = sso
25552517
response = self.json_api_call('POST',
2556-
'/admin/v2/integrations',
2557-
params,
2558-
)
2518+
'/admin/v1/integrations',
2519+
params)
25592520
return response
25602521

25612522
def delete_integration(self, integration_key):
@@ -2567,12 +2528,8 @@ def delete_integration(self, integration_key):
25672528
25682529
"""
25692530
integration_key = six.moves.urllib.parse.quote_plus(str(integration_key))
2570-
path = '/admin/v2/integrations/%s' % integration_key
2571-
return self.json_api_call(
2572-
'DELETE',
2573-
path,
2574-
{},
2575-
)
2531+
path = '/admin/v1/integrations/%s' % integration_key
2532+
return self.json_api_call('DELETE', path, {})
25762533

25772534
def update_integration(self,
25782535
integration_key,
@@ -2594,8 +2551,7 @@ def update_integration(self,
25942551
ip_whitelist=None,
25952552
ip_whitelist_enroll_policy=None,
25962553
groups_allowed=None,
2597-
self_service_allowed=None,
2598-
sso=None):
2554+
self_service_allowed=None):
25992555
"""Updates an integration.
26002556
26012557
integration_key - The key of the integration to update. (required)
@@ -2620,9 +2576,6 @@ def update_integration(self,
26202576
reset_secret_key - <any value>|None
26212577
groups_allowed - <str: CSV list of gkeys of groups allowed to auth>
26222578
self_service_allowed - True|False|None
2623-
sso - <dict: parameters for generic single sign-on> (optional)
2624-
New argument for unreleased feature. Will return an error if used.
2625-
Client will be updated again in the future when feature is released.
26262579
26272580
If any value other than None is provided for 'reset_secret_key'
26282581
(for example, 1), then a new secret key will be generated for the
@@ -2634,7 +2587,7 @@ def update_integration(self,
26342587
26352588
"""
26362589
integration_key = six.moves.urllib.parse.quote_plus(str(integration_key))
2637-
path = '/admin/v2/integrations/%s' % integration_key
2590+
path = '/admin/v1/integrations/%s' % integration_key
26382591
params = {}
26392592
if name is not None:
26402593
params['name'] = name
@@ -2676,17 +2629,11 @@ def update_integration(self,
26762629
params['groups_allowed'] = groups_allowed
26772630
if self_service_allowed is not None:
26782631
params['self_service_allowed'] = '1' if self_service_allowed else '0'
2679-
if sso is not None:
2680-
params['sso'] = sso
26812632

26822633
if not params:
26832634
raise TypeError("No new values were provided")
26842635

2685-
response = self.json_api_call(
2686-
'POST',
2687-
path,
2688-
params,
2689-
)
2636+
response = self.json_api_call('POST', path, params)
26902637
return response
26912638

26922639
def get_admins(self, limit=None, offset=0):

0 commit comments

Comments
 (0)