From e727ca6d9d05ee70c27fcb9b74f9e1966826ae86 Mon Sep 17 00:00:00 2001
From: Michael <michael.mullen@dvsa.gov.uk>
Date: Wed, 10 Jul 2024 11:55:28 +0100
Subject: [PATCH] feat(CB2-12695): update eslint rules

---
 .eslintrc.json                  | 22 +++++++++++++++++++++-
 src/utils/ExtractTestResults.ts |  4 ++--
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 6c9e93e..b084042 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -1,3 +1,23 @@
 {
-  "extends": ["@dvsa/eslint-config-ts", "prettier"]
+  "extends": ["@dvsa/eslint-config-ts", "prettier"],
+  "settings": {
+    "import/resolver": {
+      "typescript": {
+        "alwaysTryTypes": true
+      }
+    }
+  },
+  "rules": {
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        "devDependencies": true
+      }
+    ],
+    "max-len":["error", {
+      "code": 150,
+      "ignoreComments": true
+    }],
+    "@typescript-eslint/no-unsafe-enum-comparison": "off"
+  }
 }
diff --git a/src/utils/ExtractTestResults.ts b/src/utils/ExtractTestResults.ts
index 089cfdc..161585c 100644
--- a/src/utils/ExtractTestResults.ts
+++ b/src/utils/ExtractTestResults.ts
@@ -37,7 +37,7 @@ export const extractMCTestResults = (record: DynamoDBRecord): MCRequest[] => {
     )
     .filter(
       (testType) =>
-        (testType.testResult as TestResults) === TestResults.PASS || (testType.testResult as TestResults) === TestResults.PRS,
+        testType.testResult === TestResults.PASS || testType.testResult === TestResults.PRS,
     )
     .filter(
       () =>
@@ -45,7 +45,7 @@ export const extractMCTestResults = (record: DynamoDBRecord): MCRequest[] => {
         testResultUnmarshall.vehicleType === 'psv' ||
         testResultUnmarshall.vehicleType === 'trl',
     )
-    .filter(() => (testResultUnmarshall.testStatus as TestStatus) === TestStatus.SUBMITTED)
+    .filter(() => testResultUnmarshall.testStatus === TestStatus.SUBMITTED)
     .map((testType : TestTypeSchema ) : MCRequest => ({
       vehicleIdentifier:
         testResultUnmarshall.vehicleType === 'trl'