From b5fdc1440b6cf76912e7fb3f7231b6d0f5355c8e Mon Sep 17 00:00:00 2001 From: Andrew Newton Date: Tue, 21 Jan 2025 15:38:09 +0000 Subject: [PATCH 1/2] fix: set share identifier to volapp as advised (#563) --- .github/workflows/run-liquibase.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-liquibase.yaml b/.github/workflows/run-liquibase.yaml index 50b753733b..91a01b464c 100644 --- a/.github/workflows/run-liquibase.yaml +++ b/.github/workflows/run-liquibase.yaml @@ -175,7 +175,7 @@ jobs: ] }" \ --scheduling-priority-override 1 \ - --share-identifier "liquibase-migrations" \ + --share-identifier "volapp" \ --query 'jobId' \ --output text) echo "job_id=$JOB_ID" >> $GITHUB_OUTPUT From 6117b4c4a7c3043ec50223fe4ba8ffbb1fe7c9d1 Mon Sep 17 00:00:00 2001 From: William Shelley Date: Tue, 21 Jan 2025 16:18:20 +0000 Subject: [PATCH 2/2] fix: incorrect secret arn (#564) --- infra/terraform/modules/service/batch.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/infra/terraform/modules/service/batch.tf b/infra/terraform/modules/service/batch.tf index 3512b4525c..2313a3069a 100644 --- a/infra/terraform/modules/service/batch.tf +++ b/infra/terraform/modules/service/batch.tf @@ -57,7 +57,7 @@ locals { secrets = [ { name = "DB_PASSWORD" - valueFrom = "arn:aws:secretsmanager:eu-west-1:${data.aws_caller_identity.current.account_id}:secret:${var.batch.api_secret_file}:olcs_api_rds_password" + valueFrom = "${var.batch.api_secret_file}:olcs_api_rds_password::" }, ] } @@ -87,7 +87,7 @@ locals { secrets = [ { name = "DB_PASSWORD" - valueFrom = "${var.batch.api_secret_file}:olcs_api_rds_password" + valueFrom = "${var.batch.api_secret_file}:olcs_api_rds_password::" }, ] }