Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we allow a single Runnable instance to run multiple times concurrently? #111

Open
randomir opened this issue Mar 19, 2019 · 0 comments
Labels
bug Something isn't working feature New feature or request question Further information is requested

Comments

@randomir
Copy link
Member

Since Runnable.run() is (via dispatch()) offloading next() to an executor, it's possible to run a single instance's next multiple times in parallel.

This is not a problem if next() does not mutate the self, but it could potentially lead to a state lost, or even a deadlock if it does.

Should be categorically ban such a behaviour, or leave the responsibility to the block/workflow developer?

@randomir randomir added bug Something isn't working feature New feature or request question Further information is requested labels Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant