Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate results in rmc preload can result in missing blob #11

Open
dwhitacre opened this issue Jul 9, 2023 · 0 comments
Open

duplicate results in rmc preload can result in missing blob #11

dwhitacre opened this issue Jul 9, 2023 · 0 comments
Labels
bug Something isn't working severity: medium

Comments

@dwhitacre
Copy link
Owner

since maps are stored in preload by trackid, and we dont fail if the blob already exists, you can get two messages in queue for the same map in download. thus the first search+download will delete the map from blob, and the second search+download will not find a blob. if tmx api is down in this scenario, then we'd be in an invalid state.

potentially could tie blobs to queue messages by like a message id or something to force the 1-1 relationship between the two. or minimally fail to preload the map at all if the blob already exists.

having a more enforced 1-1 relationship will ultimately be better for the rmc preload, but we lose flexibility in this api for other usecases. as basically you wont be able to download a map from the cache unless it came from a queue message

@dwhitacre dwhitacre added bug Something isn't working severity: medium labels Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity: medium
Projects
None yet
Development

No branches or pull requests

1 participant