-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom header #25
Comments
@michaelmior agree. that would be super useful. |
I am not sure what people need as far as customising headers. Obvs not being able to set the title is a problem, I'll make a pull tonight! |
@michaelmior Feel free to elaborate on suggested requirements! @des-des Thanks! |
Thanks for the quick responses all! I'm enjoying ampl so far. My current use case is to integrate it with my static site generator so I can automatically produce AMP-enabled portions of some of my pages. There are a couple things I can think of off the top of my head that would be useful:
|
Another important thing I realized is that there should be a way to specify the canonical URL. |
also made this function recursive. related: #25
@michaelmior can you please confirm if this change 154197f serves your purpose. thanks! 👍 |
It looks like it does :) Although I've since decided that it's easier for me to just build all the AMP HTML myself so I'm not currently using ampl. I think there's still potential for it to be very useful. This change is definitely a step in the right direction. |
@michaelmior what made you decide to build the AMP HTML features yourself? |
Those are the right questions to ask :) I decided to produce an AMP version of my personal blog. I didn't need any of the image features provided by ampl and I needed some header customizations. This meant I wasn't really deriving a lot of benefit. It might be helpful to include easy ways to add other components such as amp-analytics. If you're curious, the source is public and you can view the template I use for AMP pages. |
@michaelmior thanks that's really helpful. :) |
It would be great if it were possible to customize the header somehow. It seems like right now you can't even change the title of the page.
The text was updated successfully, but these errors were encountered: