Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for 'equivalency' with JSLint #190

Open
eliasmalik opened this issue Sep 21, 2016 · 1 comment
Open

test for 'equivalency' with JSLint #190

eliasmalik opened this issue Sep 21, 2016 · 1 comment

Comments

@eliasmalik
Copy link
Contributor

Write a test that checks that code that fails the JSLint (with default settings) also fails our eslint config.

I put equivalency in quotes because we may decide that there is a good reason to break from a specific aspect of the good parts, in which case the equivalency test can be weakened, but that needs to be explicitly and well justified in an issue.

@jrans
Copy link
Member

jrans commented Sep 21, 2016

I think from current setup proposed in #191 we can make sure all passing fixtures in our test runner also pass jslint, using https://github.com/douglascrockford/JSLint/blob/master/jslint.js with abiility to add exceptions if so desire. node-jslint can help this process.

This can be a preliminary measure to be improved. We may therefore want to provide passing cases for ignored rules.

We also obviously need all jslints failing tests to fail ours if we can find their test fixtures

@jrans jrans mentioned this issue Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants