Label sync fail but appears as success

[iteles]

I've just tried to sync the labels with https://github.com/mosteirodelandim/landim-website/issues/labels and got the 'label sync successful!' message, but in actual fact, the labels remained the same.

When I tried to sync again by inputting the org and repo into the app, I got the following extra dialogue (new success message and second set of boxes):

Clicking re-sync also yielded no results.

[nelsonic]

Bug confirmed. Don't have access to the Fly App to debug (on this computer ...) so will have to be later/Monday. 💭

[SimonLab]

Thanks @iteles for reporting this bug.
I think it's a permission issue which is wrongly reported as correct why the labels are copied.
I'll add more checks and send back an error message for this case.

[SimonLab]

Updating the following function to make sure all the api request to Github return without any errors:

labels/lib/labels_web/controllers/page_controller.ex

Lines 105 to 121 in 6e5c767

	defp create_or_update_labels(token, owner, repo, source_labels, target_labels) do
	target_label_names = Enum.map(target_labels, & &1["name"])
	source_labels
	|> Enum.map(fn label ->
	if Enum.member?(target_label_names, label["name"]) do
	updated_label = Map.put(label, :new_name, label["name"])
	Task.async(github_api(), :update_label, [token, owner, repo, label["name"], updated_label])
	else
	Task.async(github_api(), :create_label, [token, owner, repo, label])
	end
	end)
	|> Enum.map(fn task -> Task.await(task) end)
	:ok
	end

• Make sure the function returns :ok or :error atom