Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: using form.buffer() and form.done() in conjunction with useHistorySync() can lead to mismatched history indexes #87

Open
dxinteractive opened this issue Mar 18, 2022 · 2 comments
Open

Bug: using form.buffer() and form.done() in conjunction with useHistorySync() can lead to mismatched history indexes #87

dxinteractive opened this issue Mar 18, 2022 · 2 comments
Labels
started

Comments

@dxinteractive
Copy link
Owner

Because form.buffer() and form.done() aren't global, and they rely on callAllChangeCallbacks() not being called in order to buffer changes.
@dxinteractive dxinteractive changed the title Bug: using form.buffer() and form.done() can lead to mismatches histories when forms are synced Bug: using form.buffer() and form.done() in conjunction with useHistorySync() can lead to mismatched history indexes Mar 18, 2022
@dxinteractive
Copy link
Owner Author

WIP: https://github.com/dxinteractive/dendriform/tree/feature/sync-stack-demo

@dxinteractive
Copy link
Owner Author

This may also be an issue with useHistorySync() and form.replace()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dxinteractive