-
Notifications
You must be signed in to change notification settings - Fork 3
Chore/rust scripts to rule them all #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snim2
wants to merge
12
commits into
experiment/whippet-3.0
Choose a base branch
from
chore/rust-scripts-to-rule-them-all
base: experiment/whippet-3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore/rust scripts to rule them all #264
snim2
wants to merge
12
commits into
experiment/whippet-3.0
from
chore/rust-scripts-to-rule-them-all
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit records the result of 'cargo init' with no changes at all to the generated files.
Note that: * We don't have a separate build script for the CI pipeline * We run 'cargo clean' before building, which might prove to be unnecessary and time consuming
This commit does not modify the hello world app that was automatically generated by 'cargo init', it just adds some tests so that we can: a) ensure the test scripts work b) set the expectation of full coverage
d3bdbda to
3f3e63d
Compare
Contributor
|
@snim2 Currently I'm getting this from |
Contributor
Author
OK, what do you get as the output of these commands? rustc --version
rustfmt --version
cargo --version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PHP code and add scripts-to-rule-them-all for Rust.
Description
This PR sets up the repo for Rust development. It:
cargo initThis PR does not:
Note that this PR merges into a new protected branch,
experiment/whippet-3.0because we may choose not to keep this code.Testing
./script/testif I've got the Brew dependencies right then you should see something like: