Allow apps to deploy different WP Core versions on prod #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we deployed the same WP Core version on all environments. To descibe the version of Core that we wish to deploy we use a movable tag, which is usually the major version tag of the latest release, e.g. 'v6'. However, this means that for patch and minor version updates, moving the movable tag will change deploys on both staging and production. This commit changes that strategy, and if there is an no environment variable defined that looks like it describes a production environment, we try to deploy to a revision called 'latest' and then fall back to the revision from the JSON file if that does not exist. Environment variables that might describe a production environment are: * 'WP_ENVIRONMENT_TYPE' - found in wp-config.php * 'WP_CONFIG_WP_ENVIRONMENT_TYPE' - specific to dxw
RobjS
reviewed
Aug 7, 2025
src/Modules/Release.php
Outdated
| $wp->clone_repo($this->application_config->wordpress->repository); | ||
| $wp->checkout($this->application_config->wordpress->revision); | ||
|
|
||
| if (getenv('WP_CONFIG_WP_ENVIRONMENT_TYPE') === false) { |
Contributor
There was a problem hiding this comment.
Do we need to tighten this up? e.g. if WP_CONFIG_WP_ENVIRONMENT_TYPE was set to production on a prod site, this would result in us deploying the latest version there (assuming the "latest" tag existed).
Contributor
Author
There was a problem hiding this comment.
sorry, forgot to rebase. I've pushed a fixup commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we deployed the same WP Core version on all environments. To descibe the version of Core that we wish to deploy we use a movable tag, which is usually the major version tag of the latest release, e.g. 'v6'.
However, this means that for patch and minor version updates, moving the movable tag will change deploys on both staging and production.
This commit changes that strategy, and if there is an no environment variable defined that looks like it describes a production environment, we try to deploy to a revision called 'latest' and then fall back to the revision from the JSON file if that does not exist.
Environment variables that might describe a production environment are:
Resolves: https://...