oops

Author: roy-dydx

protocol/lib/big_math.go

@@ -103,9 +103,11 @@ func BigRatMulPpm(input *big.Rat, ppm uint32) *big.Rat {
 	)
 }
 
+var OneMillionUint256 = uint256.NewInt(1_000_000)
+
 func MulPpmUint256(input *uint256.Int, ppm uint32) *uint256.Int {
 	result := new(uint256.Int).Mul(input, uint256.NewInt(uint64(ppm)))
-	return result.Div(result, uint256.NewInt(1_000_000))
+	return result.Div(result, OneMillionUint256)
 }
 
 // bigGenericClamp is a helper function for BigRatClamp and BigIntClamp

protocol/x/subaccounts/keeper/subaccount.go

@@ -457,7 +457,7 @@ func (k Keeper) CanUpdateSubaccountsUint256(
 	}
 
 	allPerps := k.perpetualsKeeper.GetAllPerpetuals(ctx)
-	success, successPerUpdate, err = k.internalCanUpdateSubaccounts(ctx, settledUpdates, updateType, allPerps)
+	success, successPerUpdate, err = k.internalCanUpdateSubaccountsUint256(ctx, settledUpdates, updateType, allPerps)
 	return success, successPerUpdate, err
 }