register deprecated vault MsgUpdateParams (#2167)

Author: tqin7

indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/tx.ts

@@ -1,6 +1,6 @@
 import { VaultId, VaultIdSDKType } from "./vault";
 import { SubaccountId, SubaccountIdSDKType } from "../subaccounts/subaccount";
-import { QuotingParams, QuotingParamsSDKType } from "./params";
+import { QuotingParams, QuotingParamsSDKType, Params, ParamsSDKType } from "./params";
 import * as _m0 from "protobufjs/minimal";
 import { DeepPartial } from "../../helpers";
 /**
@@ -107,6 +107,32 @@ export interface MsgSetVaultQuotingParamsResponse {}
  */
 
 export interface MsgSetVaultQuotingParamsResponseSDKType {}
+/**
+ * MsgUpdateParams is the Msg/UpdateParams request type.
+ * Deprecated since v6.x as is replaced by MsgUpdateDefaultQuotingParams.
+ */
+
+/** @deprecated */
+
+export interface MsgUpdateParams {
+  authority: string;
+  /** The parameters to update. Each field must be set. */
+
+  params?: Params;
+}
+/**
+ * MsgUpdateParams is the Msg/UpdateParams request type.
+ * Deprecated since v6.x as is replaced by MsgUpdateDefaultQuotingParams.
+ */
+
+/** @deprecated */
+
+export interface MsgUpdateParamsSDKType {
+  authority: string;
+  /** The parameters to update. Each field must be set. */
+
+  params?: ParamsSDKType;
+}
 
 function createBaseMsgDepositToVault(): MsgDepositToVault {
   return {
@@ -393,4 +419,59 @@ export const MsgSetVaultQuotingParamsResponse = {
     return message;
   }
 
+};
+
+function createBaseMsgUpdateParams(): MsgUpdateParams {
+  return {
+    authority: "",
+    params: undefined
+  };
+}
+
+export const MsgUpdateParams = {
+  encode(message: MsgUpdateParams, writer: _m0.Writer = _m0.Writer.create()): _m0.Writer {
+    if (message.authority !== "") {
+      writer.uint32(10).string(message.authority);
+    }
+
+    if (message.params !== undefined) {
+      Params.encode(message.params, writer.uint32(18).fork()).ldelim();
+    }
+
+    return writer;
+  },
+
+  decode(input: _m0.Reader | Uint8Array, length?: number): MsgUpdateParams {
+    const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
+    let end = length === undefined ? reader.len : reader.pos + length;
+    const message = createBaseMsgUpdateParams();
+
+    while (reader.pos < end) {
+      const tag = reader.uint32();
+
+      switch (tag >>> 3) {
+        case 1:
+          message.authority = reader.string();
+          break;
+
+        case 2:
+          message.params = Params.decode(reader, reader.uint32());
+          break;
+
+        default:
+          reader.skipType(tag & 7);
+          break;
+      }
+    }
+
+    return message;
+  },
+
+  fromPartial(object: DeepPartial<MsgUpdateParams>): MsgUpdateParams {
+    const message = createBaseMsgUpdateParams();
+    message.authority = object.authority ?? "";
+    message.params = object.params !== undefined && object.params !== null ? Params.fromPartial(object.params) : undefined;
+    return message;
+  }
+
 };

proto/dydxprotocol/vault/tx.proto

@@ -80,3 +80,15 @@ message MsgSetVaultQuotingParams {
 // MsgSetVaultQuotingParamsResponse is the Msg/SetVaultQuotingParams response
 // type.
 message MsgSetVaultQuotingParamsResponse {}
+
+// MsgUpdateParams is the Msg/UpdateParams request type.
+// Deprecated since v6.x as is replaced by MsgUpdateDefaultQuotingParams.
+message MsgUpdateParams {
+  option deprecated = true;
+  // Authority is the address that controls the module.
+  option (cosmos.msg.v1.signer) = "authority";
+  string authority = 1 [ (cosmos_proto.scalar) = "cosmos.AddressString" ];
+
+  // The parameters to update. Each field must be set.
+  Params params = 2 [ (gogoproto.nullable) = false ];
+}

protocol/app/msgs/all_msgs.go

@@ -245,6 +245,7 @@ var (
 		"/dydxprotocol.vault.MsgSetVaultQuotingParamsResponse":      {},
 		"/dydxprotocol.vault.MsgUpdateDefaultQuotingParams":         {},
 		"/dydxprotocol.vault.MsgUpdateDefaultQuotingParamsResponse": {},
+		"/dydxprotocol.vault.MsgUpdateParams":                       {},
 
 		// vest
 		"/dydxprotocol.vest.MsgSetVestEntry":            {},

protocol/app/msgs/unsupported_msgs.go

@@ -5,6 +5,7 @@ import (
 	gov "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
 	govbeta "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
 	icacontrollertypes "github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/controller/types"
+	vaulttypes "github.com/dydxprotocol/v4-chain/protocol/x/vault/types"
 )
 
 var (
@@ -28,5 +29,10 @@ var (
 		"/ibc.applications.interchain_accounts.controller.v1.MsgUpdateParams": &icacontrollertypes.
 			MsgUpdateParams{},
 		"/ibc.applications.interchain_accounts.controller.v1.MsgUpdateParamsResponse": nil,
+
+		// vault
+		// MsgUpdateParams is deprecated since v6.x and replaced by MsgUpdateDefaultQuotingParams.
+		// nolint:staticcheck
+		"/dydxprotocol.vault.MsgUpdateParams": &vaulttypes.MsgUpdateParams{},
 	}
 )

protocol/app/msgs/unsupported_msgs_test.go

@@ -16,6 +16,8 @@ func TestUnsupportedMsgSamples_Key(t *testing.T) {
 		"/cosmos.gov.v1beta1.MsgSubmitProposal",
 		"/cosmos.gov.v1beta1.MsgSubmitProposalResponse",
 
+		"/dydxprotocol.vault.MsgUpdateParams",
+
 		// ICA Controller messages
 		"/ibc.applications.interchain_accounts.controller.v1.MsgRegisterInterchainAccount",
 		"/ibc.applications.interchain_accounts.controller.v1.MsgRegisterInterchainAccountResponse",

protocol/lib/ante/nested_msg_test.go

@@ -12,6 +12,7 @@ import (
 	"github.com/dydxprotocol/v4-chain/protocol/lib"
 	"github.com/dydxprotocol/v4-chain/protocol/lib/ante"
 	testmsgs "github.com/dydxprotocol/v4-chain/protocol/testutil/msgs"
+	vaulttypes "github.com/dydxprotocol/v4-chain/protocol/x/vault/types"
 
 	"github.com/stretchr/testify/require"
 )
@@ -70,6 +71,10 @@ func TestIsDydxMsg_Invalid(t *testing.T) {
 		appmsgs.AppInjectedMsgSamples,
 		appmsgs.NormalMsgsDydxCustom,
 		appmsgs.InternalMsgSamplesDydxCustom,
+		map[string]sdk.Msg{
+			// nolint:staticcheck
+			"/dydxprotocol.vault.MsgUpdateParams": &vaulttypes.MsgUpdateParams{},
+		},
 	)
 	allMsgsMinusDydx := lib.MergeAllMapsMustHaveDistinctKeys(appmsgs.AllowMsgs, appmsgs.DisallowMsgs)
 	for key := range allDydxMsgs {

protocol/lib/ante/unsupported_msgs.go

@@ -5,6 +5,7 @@ import (
 	gov "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
 	govbeta "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
 	icacontrollertypes "github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/controller/types"
+	vaulttypes "github.com/dydxprotocol/v4-chain/protocol/x/vault/types"
 )
 
 // IsUnsupportedMsg returns true if the msg is unsupported by the app.
@@ -18,7 +19,11 @@ func IsUnsupportedMsg(msg sdk.Msg) bool {
 		// ------- CosmosSDK default modules
 		// gov
 		*govbeta.MsgSubmitProposal,
-		*gov.MsgCancelProposal:
+		*gov.MsgCancelProposal,
+		// ------- dYdX custom modules
+		// vault
+		// nolint:staticcheck
+		*vaulttypes.MsgUpdateParams:
 		return true
 	}
 	return false

protocol/x/vault/types/codec.go

@@ -3,14 +3,22 @@ package types
 import (
 	"github.com/cosmos/cosmos-sdk/codec"
 	cdctypes "github.com/cosmos/cosmos-sdk/codec/types"
+	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/types/msgservice"
+	"github.com/cosmos/gogoproto/proto"
 	"github.com/dydxprotocol/v4-chain/protocol/app/module"
 )
 
 func RegisterCodec(cdc *codec.LegacyAmino) {}
 
 func RegisterInterfaces(registry cdctypes.InterfaceRegistry) {
 	msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)
+	// Register deprecated MsgUpdateParams as it's not part of msg service.
+	registry.RegisterInterface(
+		"/"+proto.MessageName(&MsgUpdateParams{}),
+		(*sdk.Msg)(nil),
+		&MsgUpdateParams{},
+	)
 }
 
 var (