From 10d173f9a579e4d5e1fed3b98d6f2f58ccc98649 Mon Sep 17 00:00:00 2001 From: Jakob Herlitz Date: Wed, 16 Aug 2023 10:46:42 -0700 Subject: [PATCH] remove use of min order base quantums --- v4-client-py/dydx4/clients/dydx_composite_client.py | 3 +-- v4-client-py/dydx4/clients/helpers/chain_helpers.py | 6 +++--- v4-client-py/pyproject.toml | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/v4-client-py/dydx4/clients/dydx_composite_client.py b/v4-client-py/dydx4/clients/dydx_composite_client.py index bcf9efc5..3d5036e8 100644 --- a/v4-client-py/dydx4/clients/dydx_composite_client.py +++ b/v4-client-py/dydx4/clients/dydx_composite_client.py @@ -215,10 +215,9 @@ def place_order_message( atomic_resolution = market['atomicResolution'] step_base_quantums = market['stepBaseQuantums'] quantum_conversion_exponent = market['quantumConversionExponent'] - min_order_base_quantums = market['minOrderBaseQuantums'] subticks_per_tick = market['subticksPerTick'] order_side = calculate_side(side) - quantums = calculate_quantums(size, atomic_resolution, step_base_quantums, min_order_base_quantums) + quantums = calculate_quantums(size, atomic_resolution, step_base_quantums) subticks = calculate_subticks(price, atomic_resolution, quantum_conversion_exponent, subticks_per_tick) order_flags = calculate_order_flags(type, time_in_force) time_in_force = calculate_time_in_force(type, time_in_force, execution, post_only) diff --git a/v4-client-py/dydx4/clients/helpers/chain_helpers.py b/v4-client-py/dydx4/clients/helpers/chain_helpers.py index 7f7493ad..0ab6b824 100644 --- a/v4-client-py/dydx4/clients/helpers/chain_helpers.py +++ b/v4-client-py/dydx4/clients/helpers/chain_helpers.py @@ -41,12 +41,12 @@ def round( def calculate_quantums( size: float, atomic_resolution: int, - step_base_quantums: int, - min_order_base_quantums: int + step_base_quantums: int, ): raw_quantums = size * 10**(-1 * atomic_resolution) quantums = round(raw_quantums, step_base_quantums) - return max(quantums, min_order_base_quantums) + # step_base_quantums functions as the minimum order size + return max(quantums, step_base_quantums) def calculate_subticks( price: float, diff --git a/v4-client-py/pyproject.toml b/v4-client-py/pyproject.toml index c133c1ba..8719c0f0 100644 --- a/v4-client-py/pyproject.toml +++ b/v4-client-py/pyproject.toml @@ -5,7 +5,7 @@ package-dir = {"" = "dydx4"} [tool.poetry] name = "dydx4" -version = "0.1.6" +version = "0.1.7" description = "dYdX v4 Client" authors = ["John Huang "] license = "MIT"