Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ImperialConfig Angular Service #984

Open
sebastianbarry opened this issue Sep 21, 2023 · 2 comments
Open

Rewrite ImperialConfig Angular Service #984

sebastianbarry opened this issue Sep 21, 2023 · 2 comments
Assignees

Comments

@sebastianbarry
Copy link

sebastianbarry commented Sep 21, 2023

Child issue of #977

  • js/config/imperial.js (has been mostly rewritten into useImperialConfig.ts anyway)

In looking at the 2 files:

@sebastianbarry sebastianbarry self-assigned this Sep 21, 2023
@JGreenlee
Copy link

Huh. Well I thought there were some functions that hadn't been rewritten yet, but I guess I already did that.
Once you've verified that imperial.js is not used anywhere, go ahead and remove it and we'll call it a day.

After that, maybe you can start to rewrite CommHelper from www/js/services.js?

@shankari
Copy link
Contributor

shankari commented Sep 22, 2023

Before we move on, we should also write tests for useImperialConfig.ts
I merged e-mission/e-mission-phone#1033 to master yesterday, so you should have a template to look at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants