-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧🌐 Automated Config Issue Form - GitHub Actions doesn't fill in Translations correctly #65
Comments
@shankari @Abby-Wheelis I created an issue for my comments! |
The other consideration I wanted to make sure - If someone fills out the form and they (1) include another language in the translations section, and (2) choose default demographics option, then will the "survey_info": {
"surveys": {
"UserProfileSurvey": {
"formPath": "json/demo-survey-v2.json",
"version": 1,
"compatibleWith": 1,
"dataKey": "manual/demographic_survey",
"labelTemplate": {
"en": "Answered",
"es": "Contestada"
}
}
}, It wasn't a problem on this issue but I just noticed this field as I was going through this PR #64 |
For the first problem you're having, it looks like in your issues that you did not select a second language in the dropdown, so both the "english" and the "spanish" sections say that they are EN -- we allow people to specify the language code, could you try editing the comment in the auto-generated issue to so it says 'es' under the heading "second language" This might raise a broader question of if we should change the defaults... |
For the second issue, that is going to be a problem - there's a place for people to input the translations in the languages, following a format, but I have managed to hardcode that those translations get slotted in as 'en' and 'es' no matter what the languages are, great catch, thank you! We'll have to re-work the way we handle that in the parsing and probably make those fields required since we need them no matter if it's the default or a custom survey. |
@Abby-Wheelis @sebastianbarry I am not sure that we need to support languages beyond |
@shankari should I hardcode the two languages as |
@Abby-Wheelis I think we should hardcode |
Since the first issue I was having was my user error, and the second issue we decided to go with hardcoded values, then this issue is good to close. |
The automated config that was created (#64) from the issue form I filled out (#63) filled in the
intro > translated text > en
field with thees
translations I put in. I filled in both sections for EN and ES in the issue form, but it only created onetranslated text
field,en
, and put the EN translations into it.The text was updated successfully, but these errors were encountered: